[AI] Refactor settings search to use SearchInput and restructure Skills tab#18876
Merged
FelixMalfait merged 4 commits intomainfrom Mar 26, 2026
Merged
[AI] Refactor settings search to use SearchInput and restructure Skills tab#18876FelixMalfait merged 4 commits intomainfrom
FelixMalfait merged 4 commits intomainfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 13 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/twenty-front/src/pages/settings/ai/components/SettingsAgentSkills.tsx">
<violation number="1" location="packages/twenty-front/src/pages/settings/ai/components/SettingsAgentSkills.tsx:65">
P2: Use a single search field for custom-object filtering instead of matching both `name` and `label`.
(Based on your team's feedback about keeping custom-object search vectors single-field.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| sortedSkills.filter((skill) => { | ||
| const searchNormalized = normalizeSearchText(searchTerm); | ||
| const matchesSearch = | ||
| normalizeSearchText(skill.name).includes(searchNormalized) || |
Contributor
There was a problem hiding this comment.
P2: Use a single search field for custom-object filtering instead of matching both name and label.
(Based on your team's feedback about keeping custom-object search vectors single-field.)
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/pages/settings/ai/components/SettingsAgentSkills.tsx, line 65:
<comment>Use a single search field for custom-object filtering instead of matching both `name` and `label`.
(Based on your team's feedback about keeping custom-object search vectors single-field.) </comment>
<file context>
@@ -0,0 +1,162 @@
+ sortedSkills.filter((skill) => {
+ const searchNormalized = normalizeSearchText(searchTerm);
+ const matchesSearch =
+ normalizeSearchText(skill.name).includes(searchNormalized) ||
+ normalizeSearchText(skill.label).includes(searchNormalized);
+
</file context>
ehconitin
commented
Mar 24, 2026
| <Icon size={theme.icon.size.md} /> | ||
| {/* TODO: remove hardcoded color */} | ||
| {/* cant fgure out what this color is from figma*/} | ||
| <Icon size={theme.icon.size.md} color="#0091FF" /> |
|
Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
Contributor
|
Thanks @ehconitin for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes - https://discord.com/channels/1130383047699738754/1480980523315626178